Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid deprecation warning for setDaemon #364

Merged

Conversation

ice1x
Copy link
Contributor

@ice1x ice1x commented Sep 7, 2024

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: 328

Description:

How do you solve it?

Set up daemon attribute instead of method calling

Special notes for your reviewer, ex. impact of this fix, design document, etc:

https://lists.denx.de/pipermail/u-boot/2023-September/531354.html

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2024

CLA assistant check
All committers have signed the CLA.

@wey-gu
Copy link
Contributor

wey-gu commented Sep 7, 2024

Great job, thanks! And welcome to the NebulaGraph community 🫡

@wey-gu wey-gu merged commit ba345a6 into vesoft-inc:master Sep 7, 2024
10 checks passed
wey-gu pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants